Moving the project to a pyproject.toml file #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the pyproject.toml file the setup.py file is obsolete and I removed it, but appveyor, and the github actions expecting a setup.py, and I dont know how to fix these things. Maybe we can replace this with python -m build . or pip install ".[all]"And maybe can we drop support for python 3.8, because its end of life, and the setuptools required for python3.8 does not support the license-files key in the pyproject.toml file, which is now standard. |
|
I moved the optional-dependencies to a single [dev] key in the pyproject.toml file so we can install all dependencies with one call pip install ".[dev]"this can replace the python setup.py install in all the GitHub actions that use this line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to test this properly it works on my machine simply with
pip install .in the project directory.
you can now specify which dependencies you want to install. If you want all dependencies for testing and building the docs you can install them with this command
pip install ".[all]"